Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-10824] Use LayerDrawable in ActivityWindow #3776

Merged
merged 4 commits into from Jan 28, 2013
Merged

[TIMOB-10824] Use LayerDrawable in ActivityWindow #3776

merged 4 commits into from Jan 28, 2013

Conversation

vishalduggal
Copy link
Contributor

Test is in JIRA

@ghost ghost assigned pingwang2011 Jan 24, 2013
Drawable bd = tfh.loadDrawable(path, false);
handleBackground(bd, opacityValue, post);

if (bgImage != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of code is the same as the function TiUIHelper.buildBackgroundDrawable(). I think it's better to change that function to public and then use it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh..Thanks. Updating now

@vishalduggal
Copy link
Contributor Author

Ready for review.

@pingwang2011
Copy link
Contributor

FR failed.
Tested KS->Base UI->Window Properties.

  1. First click Change BG Color, and then click Toggle Opacity. But actually the opacity is not toggled. Expected behavior: the window bg should become translucent.
  2. Click ToggleHeight/Width twice. The background color is changed. Expected behavior: the background color should stay the same.

@vishalduggal
Copy link
Contributor Author

The First case is addressed.
The second fail case is invalid.
Basically you have an ActivityWindow without a background drawable. So it becomes transparent. If you follow the path
Change BGImage ->Toggle Width/Height->Toggle Width/Height, the window will not be transparent since there is a backgroundImage.
Need to update KS for this

@pingwang2011
Copy link
Contributor

Code reviewed and functionally tested. Ran two test cases and KS->Base UI->Window Properties. All passed. Accepted

pingwang2011 added a commit that referenced this pull request Jan 28, 2013
[TIMOB-10824] Use LayerDrawable in ActivityWindow
@pingwang2011 pingwang2011 merged commit fcfca53 into tidev:master Jan 28, 2013
@vishalduggal vishalduggal deleted the timob-10824 branch October 27, 2014 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants