New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-10824] Use LayerDrawable in ActivityWindow #3776
Conversation
Drawable bd = tfh.loadDrawable(path, false); | ||
handleBackground(bd, opacityValue, post); | ||
|
||
if (bgImage != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of code is the same as the function TiUIHelper.buildBackgroundDrawable(). I think it's better to change that function to public and then use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duh..Thanks. Updating now
Ready for review. |
FR failed.
|
The First case is addressed. |
Code reviewed and functionally tested. Ran two test cases and KS->Base UI->Window Properties. All passed. Accepted |
[TIMOB-10824] Use LayerDrawable in ActivityWindow
Test is in JIRA