TIMOB-4583 DOMImplementation tests #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| valueOf(testDoc.documentElement.namespaceURI).shouldBeNull(); | ||
| valueOf(testDoc.documentElement.nodeName).shouldBe("the_root"); | ||
| valueOf(testDoc.documentElement.localName).shouldBe("the_root"); | ||
| valueOf(testDoc.doctype).shouldNotBeNull(); |
There was a problem hiding this comment.
should we also check that testDoc.doctype == doctype here?
|
When testing on 2.2 device, the following error occurs: http://pastie.org/2389077 When running on Honeycomb device, XML drillbit test runs without issue on device. |
|
Functional and Code review accepted on 2.2 emulator. Opie's log indicates another stack overflow this time from the XML parser -- our only real option at this point is to either spawn a new thread for parsing so we get a clean stack, or switch runtimes. |
|
Code review passed. Accepted. |
marshall
added a commit
that referenced
this pull request
Aug 22, 2011
TIMOB-4583 DOMImplementation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-4583