[TIMOB-9593] Use data scheme when setting html text #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This change will break some existed behavior. If there are some images referred in the html, those images can not be found because the base url is "data://". I attached another test case in JIRA to show this. |
|
Actually the test case is incorrect. It is absolutely incorrect to assume that the base URL will refer to android resources directory. Anyway if you want to set a specific baseURL property you must use the setHtml(Object,Dictionary) option. |
|
Code reviewed and functionally tested. Ran the test case and KS->Base UI->View->Web Views. All passed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Jan 28, 2013
[TIMOB-9593] Use data scheme when setting html text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in JIRA