Timob 10422 Move Facebook to SDK3.1, iOS 6, and to its own module. #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: iphone/iphone/Titanium.xcodeproj/project.pbxproj
… 6, armv7s, omgwtfbbq8, 10-4
|
Module PR has not been accepted and is pending comments from reviewers. |
|
Functionally Tested and REJECTED . There seems to be some sort of a error on Facebook's Login VIew which seems error out when try to log in. |
|
Functionally Tested and accepted hold off on the merge untill the modules ticket is merged in. |
|
Functionally Tested and ACCEPTED again.... Holding off on merge until the modules PR is merged in. |
…pringtime fresh with better docs.
|
No logical changes, only docs. Still passed CR and FR. Merging. |
WhichKatieDid
added a commit
that referenced
this pull request
Feb 7, 2013
Timob 10422 Move Facebook to SDK3.1, iOS 6, and to its own module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using iOS 6 auth requires testing with a app set up where the FB app knows the native app's bundle ID. Contact me if you want such an app.