[TIMOB-10492] MobileWeb: only odd sections had separator line #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like a typo
|
Thank you for your commit. We need a ticket associated with each pull request so it can be properly tested. Can you please create one or find one as mentioned in the pull request guide? |
| @@ -192,7 +192,7 @@ define(['Ti/_/declare', 'Ti/_/UI/KineticScrollView', 'Ti/_/style', 'Ti/_/lang', | |||
| }, | |||
|
|
|||
| _refreshSections: function() { | |||
| for (var i = 0; i < this._sections._children.length; i += 2) { | |||
| for (var i = 0; i < this._sections._children.length; i += 1) { | |||
There was a problem hiding this comment.
Please change this to i++ instead of i += 1.
There was a problem hiding this comment.
Silly question: Wouldn't this run faster as:
var c=this._sections._children;
for (var i = 0; i < c.length;) c[i++]._refreshRows();
?
|
Thank you. It appears that this contributor has closed the originating repository. If you are still interested in this addition, please let us know and we can reopen a new PR with updated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting table data after table creation, rows in even sections had transparent separator lines.
Looks like a typo.