[TIMOB-12305] Control overScrollMode for scrolling containers #3841
Conversation
ghost
assigned 
|
|
||
| @Kroll.constant public static final int OVER_SCROLL_ALWAYS = 0 ; //android.view.View.OVER_SCROLL_ALWAYS; | ||
| @Kroll.constant public static final int OVER_SCROLL_IF_CONTENT_SCROLLS = 1; //android.view.View.OVER_SCROLL_IF_CONTENT_SCROLLS; | ||
| @Kroll.constant public static final int OVER_SCROLL_NEVER = 2; //android.view.View.OVER_SCROLL_NEVER; |
There was a problem hiding this comment.
We should just set these to View.Over_SCROLL_ALWAYS instead of the actual value like we do with other android constants.
There was a problem hiding this comment.
Will crash on Android 2.2. Hence the constants
|
Code reviewed, left one comment. |
|
During the functional test, I noticed that overscroll property doesn't really work for scrollable view/ webview on my galaxy SII ( 2.3 device). Is this expected? |
|
We are only controlling the overscroll mode. Not the edge effects associated with the oversroll event. On S2 running 2.3.6 the edge effects are only defined for the table view I think. Starting from 3.0 I think edge effects are defined for all scrolling containers. |
|
Code reviewed and functionally tested. Request Accepted |
[TIMOB-12305] Control overScrollMode for scrolling containers
JIRA TICKET
Test is in comments for all 4 scrolling containers.