TIMOB-11298-propagate layout properties in animation back to proxy after... #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter animation is done
| || TiC.PROPERTY_BACKGROUND_COLOR.equals(key)) { | ||
| viewProxy.setProperty((String) key, options.get(key)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a reason why we are only propagating the layout properties? Can't we just call applyProperties() on the view proxy?
There was a problem hiding this comment.
I had looked at it but the applyProperties takes everything from the options and call setProperty. Some of these properties are very specific to animation and doesn't make sense to the View.
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Feb 12, 2013
TIMOB-11298-propagate layout properties in animation back to proxy after...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-11298 - Propagate the layout properties from animation after the animation is completed.