New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-12620 Added setter for TableView.sections property per documentation #3849
Conversation
…ated documentation with corrected since date and a few typo fixes.
if (args != null && args.length > 0 && args[0] instanceof Object[]) { | ||
data = (Object[]) args[0]; | ||
} | ||
for (Object section : args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
for (Object section: data)
Updated. The sections setter now returns without changing the table if any of the objects in the array are not sections (for example, sections = [ row ]). This checking does not take place when you set sections in the construction dict, which seems consistent with the way we handle "data" in the construction dict. If you think we should reject non-sections in the construction dict as well, I think we could do something like this:
|
} | ||
for (Object section : data) { | ||
if (! (section instanceof TableViewSectionProxy)) { | ||
Log.e(TAG, "Unable to set sections. Invalid type for section: " + section); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style is not right here. Should use tab instead of whitespace.
Code reviewed and functionally tested. Looks good. Only one minor comment. |
Updated. Please review. |
Accepted |
TIMOB-12620 Added setter for TableView.sections property per documentation
Also updated documentation with corrected since date and a few typo fixes.