TIMOB-11999-Added setDatabaseEnabled and setDatabasePath on WebSettings ... #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs to enable persistant local storage
| File path = TiApplication.getInstance().getFilesDir(); | ||
| if (path != null) { | ||
| settings.setDatabasePath(path.getAbsolutePath()); | ||
| } |
There was a problem hiding this comment.
We should only enable database when we are also able to set the path. It's not guaranteed to work correctly if you enable the database, without setting a path.
…h - Review Comment
|
Incorporated review comments |
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Feb 14, 2013
TIMOB-11999-Added setDatabaseEnabled and setDatabasePath on WebSettings ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-11999-Set the properties DatabaseEnabled and DatabasePath on WebSettings to enable local storage