Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timob-11888: update doc for the supported events on TabGroup #3889

Merged
merged 3 commits into from Feb 22, 2013

Conversation

pingwang2011
Copy link
Contributor

@ghost ghost assigned hieupham007 Feb 20, 2013
@negupta
Copy link
Contributor

negupta commented Feb 22, 2013

It should also be reviewed by Arthur or Ben.

@hieupham007
Copy link
Contributor

Doc reviewed. Looks good. Waiting for Arthur or Ben to take a second look.

By default this event would trigger the current activity to be finished
and removed from the task stack. Subscribing to this event with a listener
will prevent the default behavior. To finish the activity from your listener
just call the *close* method of the tab group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close should be enclosed with backticks --- close

@bhatfield
Copy link
Contributor

Reviewed, and ran validate and deploy. DR approved with minor comment.

@pingwang2011
Copy link
Contributor Author

Updated.

bhatfield pushed a commit that referenced this pull request Feb 22, 2013
timob-11888: update doc for the supported events on TabGroup
@bhatfield bhatfield merged commit 5b69876 into tidev:master Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants