[TIMOB-9819] added null check to prevent the crash #3906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this actually fixes the issue, it just prevents it from crashing. I'd be interested to see why the native view is not set on a heavy weight window. We need to find a more complete solution since we'll probably get a bug later on saying that background gradients won't work with heavy weight windows. |
|
I have fixed the issue with gradient by using getNativeView which is overriden by TiUIActivityWindow. Let me know if there any additional fix needed |
|
Fixed by other PR: #4239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash but gradient won't be applied. nativeView is never set in TiUIView in the case of heavyweight window.
https://jira.appcelerator.org/browse/TIMOB-9819