[TIMOB-3035]iOS: EventKit module #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| description: | | ||
| Always returns `AUTHORIZATION_AUTHORIZED` on iOS pre-6.0. | ||
|
|
||
| If `contactsAuthorization` is `AUTHORIZATION_RESTRICTED`, you should not |
There was a problem hiding this comment.
contactsAuthorization? Also, what sort of issues? (If Apple is vague, can we link to their docs?)
|
|
||
| -(EKEventStore*)store | ||
| { | ||
| if (store == NULL) { |
There was a problem hiding this comment.
Minor quibble. For Obj-C objects, we should use nil.
| if (result == NO || error != nil) { | ||
| DebugLog(@"Unable to remove event from eventStore."); | ||
| NSDictionary *errorEvent = [NSDictionary dictionaryWithObject:NUMINT(result) forKey:@"result"]; | ||
| [self fireEvent:@"complete" withObject:errorEvent errorCode:[error code] message:[TiUtils messageFromError:error]]; |
There was a problem hiding this comment.
Is there ever a time we fire a complete that's successful?
There was a problem hiding this comment.
i have no clue why its even there. removed in next commit.
|
Talked with Sabil for new commit on things that need doing. |
|
CR and FR passed. Pressing big green button. |
WhichKatieDid
added a commit
that referenced
this pull request
Mar 12, 2013
[TIMOB-3035]iOS: EventKit module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventKit module contains:
** Basic Calendar fetching and reading all of its properties.
** Accessing, modify and delete events.
** Create , update alerts
** Create, delete recurrence rules for events.
There are some sample code for testing within the documentation.
Detailed testing code will be provided along with JIRA TICKET