[TIMOB-13013] iOS: ListView - Add support for events from cell controls #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2013 23:58
…llCallback to KrollWrapper
…ew templates to TiViewTemplate
…istViewProxy to prevent gc
ghost
assigned 
| TiThreadPerformOnMainThread(^{ | ||
| [self.listView setTemplates_:templates]; | ||
| }, NO); | ||
| [templates release]; |
There was a problem hiding this comment.
Shouldn't this be inside the block to ensure that we do not release too early?
added 9 commits
March 13, 2013 16:50
|
Code Reviewed and functionally tested. Am accepting this PR. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Mar 15, 2013
[TIMOB-13013] iOS: ListView - Add support for events from cell controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-13013
Also fixes some proxy memory leaks with custom templates.
Test case attached to TIMOB-13014