[TIMOB-13162] Functions assigned to proxy property may be garbage collected #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not find a signed CLA in place. Did you sign one? |
|
Hi, I've just signed CLA. On Fri, Apr 19, 2013 at 10:09 PM, Neeraj Gupta notifications@github.comwrote:
|
|
Signed CLA is in place. |
|
The problem with this is that a JSProtect without a JSUnprotect will cause memory leaks. |
|
KrollWrapper objects unprotects js object on deallocation. I think everything should be all right. |
|
Fair enough. CR approved. |
|
Functionally Tested and APPROVED |
srahim
added a commit
that referenced
this pull request
Jul 17, 2013
[TIMOB-13162] Functions assigned to proxy property may be garbage collected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See problem details in the corresponding JIRA issue.