Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-13145] ensure to register local protocol handler when load from string/data #3999

Merged
merged 1 commit into from Mar 21, 2013
Merged

[TIMOB-13145] ensure to register local protocol handler when load from string/data #3999

merged 1 commit into from Mar 21, 2013

Conversation

mstepanov
Copy link
Contributor

@ghost ghost assigned vishalduggal Mar 21, 2013
@vishalduggal
Copy link
Contributor

Wouldn't it be easier to just register the protocol handler in the webview initialization?

@mstepanov
Copy link
Contributor Author

registering protocol handler to early could be overridden by default file protocol handler

@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

FR Passed. APPROVED

vishalduggal added a commit that referenced this pull request Mar 21, 2013
@vishalduggal
Merge pull request #3999 from mstepanov/timob-13145
57dc4f7 
[TIMOB-13145] ensure to register local protocol handler when load from string/data
@vishalduggal vishalduggal merged commit 57dc4f7 into tidev:master Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vishalduggal vishalduggal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstepanov @vishalduggal