TIMOB-12930 The dangers of copy-pasting at the last moment. #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad two, two, two regressions for the price of one!
|
Code reviewed and functionally tested. Ran anvil and verified that the two tests passed: doublePrecision and stringFormatCurrency. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Mar 25, 2013
TIMOB-12930 The dangers of copy-pasting at the last moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9995dc3 had two, two, two regressions for the price of one!
How embarrassing. The two errors found by Anvil were caused by another typo of the same type.
<Error: should be: '1364098279905', was: '1364098285568'\n at [object Object].reportError (testUtil.js:25:10)\n at [object Object]. (testUtil.js:77:9)\n at [object Object].doublePrecision (suites/properties.js:123:27)\n at [object Objec
<Error: should be: '$555,123.23', was: '$555,123.25'\n at [object Object].reportError (testUtil.js:25:10)\n at [object Object]. (testUtil.js:77:9)\n at [object Object].stringFormatCurrency (suites/android/android_string.js:331:30)\n at
Anyways, test is in Anvil.