Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-13064] iOS: Date Picker getValue() returns null #4037

Merged
merged 2 commits into from Mar 27, 2013
Merged

[TIMOB-13064] iOS: Date Picker getValue() returns null #4037

merged 2 commits into from Mar 27, 2013

Conversation

mstepanov
Copy link
Contributor

TIMOB-13064

Test case in JIRA

@ghost ghost assigned srahim Mar 26, 2013
@@ -212,6 +212,14 @@ -(void)setValue_:(id)date
}
}

- (id)value_
{
if ([self isDatePicker]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should check the type also (ie datePIckerMode) for UIDatePickerModeCountDownTimer, UIDatePickerModeDateAndTime, UIDatePickerModeDate cause all of them result in datepicker

@srahim
Copy link
Contributor

srahim commented Mar 27, 2013

Code reviewed and left comments.

@srahim
Copy link
Contributor

srahim commented Mar 27, 2013

Code Reviewed and APPROVED

@srahim
Copy link
Contributor

srahim commented Mar 27, 2013

FT - APPROVED

srahim added a commit that referenced this pull request Mar 27, 2013
[TIMOB-13064] iOS: Date Picker getValue() returns null
@srahim srahim merged commit cd47400 into tidev:master Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants