Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-13052] (2_1_X) Android: TableViewRow index confused in row click #4055

Merged
merged 7 commits into from Apr 1, 2013
Merged

[TIMOB-13052] (2_1_X) Android: TableViewRow index confused in row click #4055

merged 7 commits into from Apr 1, 2013

Conversation

vishalduggal
Copy link
Contributor

Test is in JIRA

Regress against KS (use the 3_0_X branch)

@ghost ghost assigned ayeung Mar 29, 2013
|| oldProperties.containsKeyAndNotNull(TiC.PROPERTY_BORDER_WIDTH);
boolean newHasBorder = newProperties.containsKeyAndNotNull(TiC.PROPERTY_BORDER_COLOR)
|| newProperties.containsKeyAndNotNull(TiC.PROPERTY_BORDER_RADIUS)
|| newProperties.containsKeyAndNotNull(TiC.PROPERTY_BORDER_WIDTH);;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra ;

@ayeung
Copy link
Contributor

ayeung commented Mar 30, 2013

Code reviewed and left comments.

Functional test looks good. Ran the test case and KS without any issues.

@vishalduggal
Copy link
Contributor Author

Ready for review.

@ayeung
Copy link
Contributor

ayeung commented Apr 1, 2013

Code reviewed and functionally tested. Request Accepted.

ayeung pushed a commit that referenced this pull request Apr 1, 2013
[TIMOB-13052] (2_1_X) Android: TableViewRow index confused in row click
@ayeung ayeung merged commit 245b50d into tidev:2_1_X Apr 1, 2013
@vishalduggal vishalduggal deleted the timob-13052 branch October 27, 2014 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants