[TIMOB-10108] MobileWeb: Ti.API.log INFO level messages do not display as correct type #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,13 +8,13 @@ define(["Ti/_/Evented", "Ti/_/lang"], function(Evented, lang) { | |||
|
|
|||
| // the order of these DOES matter... it uses the last known function | |||
| // (i.e. if trace() does not exist, it'll use debug() for trace) | |||
| fns = ["debug", "trace", "error", "fatal", "critical", "info", "notice", "log", "warn"]; | |||
|
|
|||
| fns = ["debug", "trace", "error", "fatal", "critical", "info", "notice", "log", "warn"] | |||
There was a problem hiding this comment.
Missing a comma at the end of the line.
| @@ -38,6 +38,12 @@ define(["Ti/_/Evented", "Ti/_/lang"], function(Evented, lang) { | |||
| })(fns[i]); | |||
| } | |||
|
|
|||
| api.log = function () { | |||
| var a = Array.prototype.slice.call(arguments); | |||
There was a problem hiding this comment.
You can also do
[].slice.call(arguments);which is shorter
There was a problem hiding this comment.
So actually, we have a method in lang called toArray that does this for you
added 2 commits
March 29, 2013 16:46
|
MW crashes with the fix. Test Code: Ti.API.debug('debug');
Ti.API.error('error');
Ti.API.info('info');
Ti.API.timestamp('timestamp');
Ti.API.trace('trace');
Ti.API.warn('warn');
Ti.API.log('log');
Ti.API.log('debug', 'debug');
Ti.API.log('error', 'error');
Ti.API.log('info', 'info');
Ti.API.log('timestamp', 'timestamp');
Ti.API.log('trace', 'trace');
Ti.API.log('warn', 'warn');Exception: |
|
Also, it turns out we have the wrong list of APIs in Ti.API. We need to be at parity with the docs: http://docs.appcelerator.com/titanium/latest/#!/api/Titanium.API |
|
After doing some digging, we should leave in notice, critical, and fatal. They aren't documented, but the other platforms are basically doing the same thing we are. We do need to add support for timestamp though. |
|
Closing because this PR is being superseded by a different one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MobileWeb: Ti.API.log INFO level messages do not display as correct type