timob-12139: Android: Textfield change event behaves differently in 2.1.4 and 3.0.0 SDK #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix the crash. fixed the "change"event.
ghost
assigned 
| { | ||
|
|
||
| if (maxLength >= 0 && editable.length() > maxLength) { | ||
| isTruncatingText = true; |
There was a problem hiding this comment.
why are you setting this to true then to false in the same function call?
|
Code reviewed. Please address comments. |
| if (cursor > maxLength) { | ||
| cursor = maxLength; | ||
| } | ||
| tv.setText(newText); |
There was a problem hiding this comment.
We set isTruncatingText to true in this if block because we truncate the characters and reset text. The function tv.setText(newText) here will directly invoke onTextChanged() and afterTextChanged() again. But maybe I should return here to make it more clear.
There was a problem hiding this comment.
return here would be a behavior change from this code. Can you comment on this code to make it more clear?
|
Updated. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Apr 9, 2013
timob-12139: Android: Textfield change event behaves differently in 2.1.4 and 3.0.0 SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-12139
Test steps in JIRA.