[TIMOB-9332] Add "centerOffset" to Map Annotations #4074
Conversation
|
I could not find a signed CLA in place. Did you sign one? |
| - (void)setCenterOffset:(id)centeroffset | ||
| { | ||
| id current = [self valueForUndefinedKey:@"centerOffset"]; | ||
| [self replaceValue:centeroffset forKey:@"centerOffset" notification:NO]; |
There was a problem hiding this comment.
Since this ultimately becomes a CGPoint, it's better to be stored as an instance variable CGPoint instead of constantly converted multiple places.
|
@jjosef Please address comments and sign the Contributor's License Agreement (CLA) at https://appcelerator.echosign.com/public/hostedForm?formid=25LBTXJ55452R |
|
@BlainHamon I have implemented using CGPoint not sure what else needs to be refactored. I could rewrite the entire function to be more comprehensive and concise, but I was trying to avoid changing too much, just needed this tweak for a client project and I thought other's would find it useful. If you think it can be improved, by all means, go ahead. |
|
I think you misunderstood the review comments. I have set up a new PR based off of your PR. Thank you for your contribution. |
https://jira.appcelerator.org/browse/TIMOB-9332 -- implemented