[TIMOB-13379] Add support for console.time and console.timeEnd #4084
Conversation
|
CLA is signed using the email matt@appersonlabs.com |
|
Signed CLA is in place. |
| @@ -14,5 +14,19 @@ -(void)log:(NSArray*)args | |||
| { | |||
| [self logMessage:args severity:@"info"]; | |||
| } | |||
| -(void)time:(NSArray*)args | |||
| { | |||
| if(!self->startTimes) { | |||
There was a problem hiding this comment.
the dereferencing is unnecessary within a method.
There was a problem hiding this comment.
Also, if checking a pointer, do not use boolean, but check == nil or != nil.
|
FR rejected. Please address comments. |
|
@mattapperson - Please let us know if you plan to address review comments or should we close this pull request? |
|
Sorry, missed this. Ill get this fixed up this week. Thanks for the poke! |
|
Bump! |
|
bump again |
|
Sorry, but my and my companies dev efforts are now focused on other efforts |
|
So no further Appcelerator dev from you?
|
|
It's just not our focuse at this time. |
Added support for iOS & Android for TIMOB-13379