Timob 13359 part 2 #4091
Merged
Timob 13359 part 2 #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e other than string.
…if 'reportSuccess' is false for third party events.
…er, success is always boolean, and that they're always tied.
|
The iOS part looks good. CR -ed for iOS and accepted_ |
| code = codeValue; | ||
| krollData.remove(TiC.PROPERTY_SUCCESS); | ||
| krollData.remove(TiC.PROPERTY_CODE); | ||
| } |
There was a problem hiding this comment.
What was the behavior before the fix? Could it have been an object like the 'error' property? If so, maybe we should log a deprecation warning like we do for that.
|
Before the original error handling is that we didn't care. There was no type for success or code enforced or checked. Not sure this is a deprecation, as we can always check and compensate. |
|
Ran basic sanity check with KS . nothing crashed.. |
|
Code reviewed and functionally tested. Request Accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for success and code to be anything and not affect error.