[TIMOB-13435] iOS: Label stuck in highlighted mode #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| if (proxy.callbackCell == self) { | ||
| [proxy prepareTableRowForReuse]; | ||
| } | ||
| [self setProxy:nil]; | ||
| //[self setProxy:nil]; |
There was a problem hiding this comment.
I'm worrying this may cause memory leaks.
There was a problem hiding this comment.
No it won't. We set the proxy explicitly in cellForRowAtIndexPath method when reusing cells.
|
Code reviewed. tentatively approved |
|
FT on linked tickets PASSED |
mstepanov
pushed a commit
that referenced
this pull request
Apr 8, 2013
[TIMOB-13435] iOS: Label stuck in highlighted mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in JIRA
Regress against
TIMOB-6384
TIMOB-6431
TIMOB-7397
Follow the trail of linked tickets in the tickets listed above (especially TIMOB-7397) to do a full pass.
Also please run Kitchen Sink