TIMOB-12658: Android: TableView row labels disappear, related to className property #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he height. This prevented children from measuring correctly since height would be zero.
ghost
assigned 
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Apr 10, 2013
TIMOB-12658: Android: TableView row labels disappear, related to className property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-12658
I had to manually set the height parameter in layout params. Before it was MATCH_PARENT, and since the parent was MeasureSpec.UNSPECIFIED, it defaulted to 0 when it got passed into onMeasure for the children.
Test case in Jira. Please also make sure to run KS.