timob-13159: Android: Images are blank/ have an empty entry when saved to the photo gallery #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ToPhotoGallery=false
ghost
assigned 
| values.put(Images.Media.TITLE, imageFile.getName()); | ||
| values.put(Images.Media.DISPLAY_NAME, imageFile.getName()); | ||
| values.put(Images.Media.DATE_TAKEN, new Date().getTime()); | ||
| values.put(Images.Media.MIME_TYPE, "image/jpeg"); | ||
| if (saveToPhotoGallery) { |
There was a problem hiding this comment.
So if we are trying to save to the gallery, we essentially don't do anything since we use the temp file? In one of the comments above you say that the temp file gets deleted when the app exits... where does this happen?
There was a problem hiding this comment.
If we are trying to save to the gallery, we will move the temp file to localPath and insert the image info to the gallery database. If we don't want to save to the gallery, we don't do anything. All the temp files will be deleted in the method TiApplication.dispose() which is called from TiBaseActivity.onDestroy().
|
Code reviewed and functionally tested. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Apr 18, 2013
timob-13159: Android: Images are blank/ have an empty entry when saved to the photo gallery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-13159
Test case in JIRA.