TIMOB-13104-override onLayout on the native control #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be done inside TiImageView, not TiUIImageView. We already overwrite onlayout() in TiImageView, so you just need to call postlayout there. |
|
I added this in TiUIImageView because the proxy was not available in the TiImageView. We could change the constructor to pass the proxy in to TiImageView. Let me know if that is ok. |
|
Let's move it into TiImageView. Make sure you create a new constructor for it. Also when you add it to TiImageView, use a weak reference for the proxy. Look at how we do this in TiCompositeLayout as an example. |
|
Code reviewed and functionally tested. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
May 15, 2013
TIMOB-13104-override onLayout on the native control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override onLayout of the native control to fire the event.
https://jira.appcelerator.org/browse/TIMOB-13104