[TIMOB-13150] Added support for prepareAsync

[salachi]

Added async support

https://jira.appcelerator.org/browse/TIMOB-13150

[pingwang2011]

If this part is deleted, the sound won't play again after the sound is paused or stopped. Please test with KS->Phone->Sound.

[salachi]

Thanks for the catch, I missed testing the 'pause'. I will fix this

[salachi]

Based on the review feedback, fixed the issue with 'pause'

[pingwang2011]

In the play() method, initialize() and startPlaying() are already in a try-catch block, so the try-catch here is not necessary. Just need to put startPlaying() in a try-catch block in the onPrepared() method.

[pingwang2011]

Since you add an Async call to prepare the media player, the states of the player have to be set in the right place. Otherwise, it will mess up the other sync methods, like stop and pause.
For example, setState(STATE_INITIALIZED) should be called in different places for sync and async preparation. If the users stop or pause the audio before the callback of the async method, the audio should not play at all. But that's not the case in this implementation. I ran the test case in the ticket, the audio still plays although it calls audioPlayer.stop() in the app.js.
BTW, after your change, it is more appropriate to rename the method initialize() to something like initializeAndPlay().

[billdawson]

Ping's comments have been addressed. However the functional test fails. I'm using this test:

https://jira.appcelerator.org/browse/TIMOB-13150?focusedCommentId=265017&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-265017

After calling stop(), there is a pause and then the stream starts again. It's because of the prepare listener (stop() calls .prepare).

[billdawson]

The re-start problem is fixed. However, stop() is holding up the thread (like start() was in the original complaint.) After stopping, it calls .prepare rather than .prepareAsync even when the source is remote. The remote variable is set and available at that point, so I think you can use it to determine whether to call .prepareAsync.

[salachi]

Added new pull request #4593