[TIMOB-13697] Added jet rockets to Mobile Web #4229
Conversation
…tarted optimizing declare().
…mizations. Some internal changes including this.constants.something is now this.__values__.constants.something and this.constants.__values__.something is now this.__values__.constants.something.
|
Please do not merge this PR until I understand the context. |
Merge branch 'master' into timob-13697 Conflicts: mobileweb/titanium/Ti/UI/View.js
… and some code tweaks.
| dest['get' + capitalizedName] = desc.get; | ||
| writable && (dest['set' + capitalizedName] = desc.set); | ||
| } | ||
| }(prop, name, propObj[name], name.substring(0, 1).toUpperCase() + name.substring(1), special[prop])); |
There was a problem hiding this comment.
FYI string.slice() takes the same arguments as string.substring() as long as the arguments are not negative and saves 4 bytes.
|
Code reviewed and tested. Request accepted |
[TIMOB-13697] Added jet rockets to Mobile Web
| @@ -99,7 +99,7 @@ define(["Ti/_", "Ti/_/declare", "Ti/_/has", "Ti/_/lang", "Ti/_/Evented", "Ti/Fil | |||
|
|
|||
| open: function(method, url, async) { | |||
| var httpURLFormatter = Ti.Network.httpURLFormatter, | |||
| c = this.constants, | |||
| c = this.__values__.constants, | |||
There was a problem hiding this comment.
This change breaks HttpClient as this.values is undefined at this point. I can change my local copy of this file but is there a fix that can be pushed?
There was a problem hiding this comment.
Hi Brenton, this pull request swapped the internal location where constants and properties are stored. This is correct. It should be this.values.constants. I'm not sure why HttpClient wouldn't be working.
Can you do me a favor and create a new ticket (http://jira.appcelerator.org/), then set the component to "MobileWeb" and assign it to me (Chris Barber)? Please include an error message and if possible, a small test case that reproduces the problem. This would help out a ton. I will take a look at it asap.
There was a problem hiding this comment.
@cb1kenobi Sorry, I already created a ticket and I am not sure if I can reassign it now. The ticket is here: https://jira.appcelerator.org/browse/TC-2738. It will try to create a sample project to recreate but I wasn't doing anything fancy... I did notice that this.constants was populated with the values I wanted so my next step was going to be to try a previous version of that file with the rest of the RC2 code and see how that works.
Do you happen know where the values property is supposed to get set so I can put a breakpoint in and see what happens?
|
I made a comment by the line, but this pull request breaks HttpClient at the open function: values is undefined at this point. I can fix my local copy but is there a fix that can be pushed? |
This PR contains major performance improvements for Mobile Web. We're seeing significantly faster object instantiation times, much faster load times, and significantly less memory usage. In addition, a few bugs were fixed:
There were some internal changes that may break Mobile Web modules and platforms such as Tizen:
Also, after this PR, Mobile Web will no longer support: