[TIMOB-13775] If the specified or default avd id does not exist, it'll t... #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l try to find an Android SDK 2.2 or newer before failing.
|
|
||
| // double check and make sure that the avd-id passed (or the default) | ||
| // exists as an android target and if not, deal with it vs. bombing | ||
| if (!isNaN(avdid) || !androidEnv.targets || !androidEnv.targets[avdid]) { |
There was a problem hiding this comment.
if a valid avd-id is passed in (say "10"), !isNaN(avdid) will evaluate to true and the entire conditional will evaluate to true, meaning avdid of 10 will be reset to 0
|
All is fixed and good (I hope). |
|
Code reviewed and tested. Request accepted |
nebrius
added a commit
that referenced
this pull request
May 9, 2013
[TIMOB-13775] If the specified or default avd id does not exist, it'll t...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ry to find an Android SDK 2.2 or newer before failing.