[TIMOB-13417] iOS: ListView V2 UI enhancements #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| //By default this is not nil. So we will add the stuff as subviews to this | ||
| UIView* superView = [self backgroundView]; | ||
| if (bgImage != nil) { | ||
| if ([_bgView isKindOfClass:[UIImageView class]] == NO) { |
There was a problem hiding this comment.
Why the check of == NO instead of !, considering this is a logical value?
|
Finished leaving comments for CR. |
|
Code Reviewed and APPROVED |
|
CR also approved. |
|
CODE REVIEWED AND approved |
srahim
added a commit
that referenced
this pull request
May 15, 2013
[TIMOB-13417] iOS: ListView V2 UI enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for TIMOB-13417
Test cases are in KitchenSink PR
During FR please also test TableView since some code was refactored that effects tableView.
Please also ensure that you run on device for FR