[TIMOB-12539] added a new property calendarViewShown #4328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @module.api | ||
| */ | ||
| public static final String PROPERTY_CALENDAR_VIEW_SHOWN = "calendarViewShown"; |
There was a problem hiding this comment.
properties are sorted alphabetically.. please place this in the correct spot instead of adding it at the end
|
Code reviewed. This PR needs to have a valid test case in the ticket. |
ghost
assigned 
| public void setCalendarView(boolean value) | ||
| { | ||
| DatePicker picker = (DatePicker) getNativeView(); | ||
| picker.setCalendarViewShown(value); |
There was a problem hiding this comment.
This call must be inside an API LEVEL CHECK >= 11
added 2 commits
July 4, 2013 14:21
| @@ -82,6 +85,9 @@ public void processProperties(KrollDict d) { | |||
|
|
|||
| this.maxDate = maxDateCalendar.getTime(); | |||
| } | |||
| if (d.containsKey(TiC.PROPERTY_CALENDAR_VIEW_SHOWN)) { | |||
| setCalendarView(TiConvert.toBoolean(d, TiC.PROPERTY_CALENDAR_VIEW_SHOWN)); | |||
| } | |||
There was a problem hiding this comment.
This whole block is formatted incorrectly.
|
Docs need to be updated. |
|
Any update on this PR? Also, please provide a valid test case for this new feature. |
|
new test case added |
|
Please add documentation to this PR. Also please merge with master, and add testing steps + expected result to the test case in JIRA. |
|
Duplicate of #4667. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new property calendarViewShown
https://jira.appcelerator.org/browse/TIMOB-12539