Timob 14060: Parity: Making the app background on Android does not send ti.end event #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ | |||
| private static final String TAG = "TitaniumAnalyticsEvent"; | |||
|
|
|||
| private static TimeZone utc = TimeZone.getTimeZone("UTC"); | |||
| private static SimpleDateFormat isoDateFormatter = | |||
| public static SimpleDateFormat isoDateFormatter = | |||
There was a problem hiding this comment.
This should not be public. It should be private and final.
|
Updated. |
| return; | ||
| } | ||
| } catch (ParseException e) { | ||
| Log.e(TAG, "Incorrect timestamp. Unable to send the ti.start event.", e); |
There was a problem hiding this comment.
shouldn't we return here instead of adding the event ?
There was a problem hiding this comment.
Although this error should not happen, I still add this event to the DB and send it to the server. Then the server side can decide to use it or discard it.
|
Code reviewed. Please address comments. |
…ys were inserted into the map.
|
Functionally Tested and APPROVED |
|
Code reviewed. Request accepted |
srahim
added a commit
that referenced
this pull request
Jun 3, 2013
Timob 14060: Parity: Making the app background on Android does not send ti.end event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14060