Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-13671- add checking only for TicompositLayout.LayoutParam #4382

Merged

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Jun 12, 2013

Added checking for TicompositLayout.LayoutParam
https://jira.appcelerator.org/browse/TIMOB-13671

@ayeung
Copy link
Contributor

ayeung commented Jun 17, 2013

Please fix the formatting on this code. There should not be a new line after each line of code.


if (view.getLayoutParams() instanceof TiCompositeLayout.LayoutParams) {

LayoutParams params = (LayoutParams)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and 640 should be on the same line.

@bijupmb
Copy link
Contributor Author

bijupmb commented Jun 20, 2013

correct the format issue.

@ayeung
Copy link
Contributor

ayeung commented Jun 20, 2013

Code reviewed and functionally tested. Request Accepted.

ayeung pushed a commit that referenced this pull request Jun 20, 2013
…IthasBorder

TIMOB-13671- add checking only for TicompositLayout.LayoutParam
@ayeung ayeung merged commit b787e94 into tidev:master Jun 20, 2013
GroupeConitech added a commit to GroupeConitech/titanium_mobile that referenced this pull request Aug 29, 2013
…AppIfIthasBorder

TIMOB-13671- add checking only for TicompositLayout.LayoutParam
GroupeConitech added a commit to GroupeConitech/titanium_mobile that referenced this pull request Oct 19, 2013
…AppIfIthasBorder

TIMOB-13671- add checking only for TicompositLayout.LayoutParam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants