Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-13922-fixed the size height issue #4388

Closed

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Jun 13, 2013

fixed the size height of button
https://jira.appcelerator.org/browse/TIMOB-13922

@ayeung
Copy link
Contributor

ayeung commented Jun 17, 2013

Closing this PR. The fix is invalid for two reason:

  1. The KS files changes are wrong and no longer used
  2. The change will fix behavior on some phones, and break behavior on other (probably older phones)

@ayeung ayeung closed this Jun 17, 2013
@bijupmb
Copy link
Contributor Author

bijupmb commented Jun 20, 2013

1.Button text size is working properly after I modified the height as 40 in window_layout.js. Could you please tell me which which file i have to modify?
2. I prefer to use auto for button height but all other buttons are used 40 as height . is it so I changed height is 40

@ayeung
Copy link
Contributor

ayeung commented Jun 20, 2013

KS is in another repo. I would just skip over this ticket for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants