[TIMOB-13416] iOS:ListView editing support #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| - (NSDictionary *)itemAtIndex:(NSUInteger)index; | ||
| - (void) deleteItemAtIndex:(NSUInteger)index; | ||
| - (void) setItemAtIndex:(NSDictionary*)item withIndex:(NSUInteger)index; |
There was a problem hiding this comment.
I'm not fully sure about the method name. Is the first argument an index, a dictionary with item and index? If it's just an item, why is index mentioned there? Also, it says set, not insert.
|
Comments left, but otherwise looks good. |
|
Code looks good from my side. went ahead and did FR .. looks all fine too me. Will wait till you can address blains comment to merge this in. |
|
Ready For Review |
|
Code Reviewed and APPROVED |
|
Functionally Tested and APPROVED |
srahim
added a commit
that referenced
this pull request
Jun 24, 2013
[TIMOB-13416] iOS:ListView editing support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TIMOB-13416
Test using KS PR 105