[TIMOB-13418] iOS: ListView pullView support #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (_pullViewWrapper == nil) { | ||
| _pullViewWrapper = [[UIView alloc] init]; | ||
| _pullViewWrapper.backgroundColor = [UIColor lightGrayColor]; |
There was a problem hiding this comment.
Should this be clearcolor in case the tableview has a custom background color?
There was a problem hiding this comment.
Moved over from tableView. Spec says nothing so keeping old behavior.
|
Notes left, but otherwise good. |
|
Code re-reviewed and APPROVED |
|
Functionally Tested and APPROVED |
srahim
added a commit
that referenced
this pull request
Jun 24, 2013
[TIMOB-13418] iOS: ListView pullView support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for TIMOB-13418
New property - pullView
New events
This events has a single custom argument
activeof type boolean.True when pullView is completely visible, false when it becomes partially visible.
The spec states contentOffset but that will not be provided for parity reasons.
Test case is in comments