TIMOB-7739 add label for prompt and implement background properties #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String strPrompt = TiConvert.toString(d, "prompt"); | ||
| promptText.setText(strPrompt); | ||
| } | ||
| if (d.containsKey("backgroundImage")) { |
There was a problem hiding this comment.
All these strings should be constants in TiC class. Some of these probably already exist there.
|
There needs to be a test case added to the ticket. |
ghost
assigned
added 2 commits
July 4, 2013 11:53
| layout.setPadding(0,0,0,0); | ||
| layout.setPadding(0, 0, 0, 0); | ||
| int promptWidth = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, 150, proxy.getActivity() | ||
| .getResources().getDisplayMetrics()); |
There was a problem hiding this comment.
Why are we restricting width to be 150 dp? You've already set it to single line and truncate at end. Why not FILL?
|
Needs a doc update and remerging with master. |
|
Please merge with master. |
|
Any update on this? |
|
NEW PR:- |
|
Closing this PR since new PR is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added properties
https://jira.appcelerator.org/browse/TIMOB-7739