[TIMOB-14270] (3_1_X)Adds support for the New Relic module's dex agent. #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Code reviewed and functionally tested. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Jun 24, 2013
[TIMOB-14270] (3_1_X)Adds support for the New Relic module's dex agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKPORT OF PR #4399
TESTING INSTRUCTIONS IN JIRA
This PR modifies the Android builder script to look for the New Relic module, and if present passes an additional argument to the dx command when it is called. This allows New Relic to do bytecode rewriting for instrumentation.
The Java agent argument to dx is passed via a temporary file to avoid issues the dx command has with spaces in file paths. This temporary file is cleaned up after dx runs.