Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-6142-added support for BroadcastIntent #4412

Merged
merged 4 commits into from Sep 11, 2013

Conversation

salachi
Copy link
Contributor

@salachi salachi commented Jun 24, 2013

Added support for BroadcastIntent

I have modified the documentation but not sure I have done it correctly

https://jira.appcelerator.org/browse/TIMOB-6142

@ayeung
Copy link
Contributor

ayeung commented Jul 1, 2013

@salachi Please add test cases to the ticket when creating a new feature.

@ghost ghost assigned vishalduggal Jul 1, 2013
@hieupham007
Copy link
Contributor

@salachi Any update on this ticket?

@salachi
Copy link
Contributor Author

salachi commented Jul 30, 2013

Updated the ticket with test case.

@salachi salachi closed this Jul 30, 2013
@salachi salachi reopened this Jul 30, 2013
@salachi
Copy link
Contributor Author

salachi commented Jul 30, 2013

Accidently closed this, reopened.

@ghost ghost assigned hieupham007 Aug 20, 2013
summary: Broadcast the passed in `Intent` to all `BroadcastReceiver`s with an optional permission.
parameters:
- name: intent
summary: Description of the activity to start.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change summary to "Description of the broadcast".

@billdawson
Copy link
Contributor

Looks great except for a few documentation changes.

FR passed. Will do final CR after documentation changes are submitted.

@@ -196,8 +216,8 @@ events:

- name: newintent
summary: Fired when the activity is already running and certain flags are set in its intent.
description: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something happened here. You moved a line? It breaks the parser.

BTW, you should always validate when you make .yml changes (doc changes). It's easy, just go to the apidoc folder and run:

python validate.py -e

The -e means to show errors only.

@billdawson
Copy link
Contributor

Almost there! Just a small .yml error.

@billdawson
Copy link
Contributor

@salachi Sunila, I must apologize, I'm afraid I made a mistake. I should not have asked you to remove the "url" property documentation from the BroadcastIntentOptions type. I didn't think we supported it, but we do.

Can you please put it back? It should look like this:

- name: url
  summary: Url for the broadcast receiver's JavaScript.
  type: String
  optional: true

Thank you, and sorry about that.

@hieupham007
Copy link
Contributor

@billdawson, Is this PR ok to merge? Looks like your comment has been addressed.

@billdawson
Copy link
Contributor

Okay, tested the apidoc generation and it looks great. Go for it @hieupham007

hieupham007 added a commit that referenced this pull request Sep 11, 2013
TIMOB-6142-added support for BroadcastIntent
@hieupham007 hieupham007 merged commit 119de36 into tidev:master Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants