New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-6142-added support for BroadcastIntent #4412
Conversation
@salachi Please add test cases to the ticket when creating a new feature. |
@salachi Any update on this ticket? |
Updated the ticket with test case. |
Accidently closed this, reopened. |
summary: Broadcast the passed in `Intent` to all `BroadcastReceiver`s with an optional permission. | ||
parameters: | ||
- name: intent | ||
summary: Description of the activity to start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change summary to "Description of the broadcast".
Looks great except for a few documentation changes. FR passed. Will do final CR after documentation changes are submitted. |
@@ -196,8 +216,8 @@ events: | |||
|
|||
- name: newintent | |||
summary: Fired when the activity is already running and certain flags are set in its intent. | |||
description: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something happened here. You moved a line? It breaks the parser.
BTW, you should always validate when you make .yml changes (doc changes). It's easy, just go to the apidoc folder and run:
python validate.py -e
The -e
means to show errors only.
Almost there! Just a small .yml error. |
@salachi Sunila, I must apologize, I'm afraid I made a mistake. I should not have asked you to remove the " Can you please put it back? It should look like this:
Thank you, and sorry about that. |
@billdawson, Is this PR ok to merge? Looks like your comment has been addressed. |
Okay, tested the apidoc generation and it looks great. Go for it @hieupham007 |
TIMOB-6142-added support for BroadcastIntent
Added support for BroadcastIntent
I have modified the documentation but not sure I have done it correctly
https://jira.appcelerator.org/browse/TIMOB-6142