Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14357] Android: TiViewProxy and TiCompositeLayout crashes due to NullPointerException #4415

Closed
wants to merge 1 commit into from

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Jun 25, 2013

Fix for NullPointerException crash symptom
https://jira.appcelerator.org/browse/TIMOB-14357

@@ -510,6 +510,7 @@ protected void onLayout(boolean changed, int l, int t, int r, int b)

for (int i = 0; i < count; i++) {
View child = getChildAt(i);
if (child == null) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would a child be null here? If a child is null, it should be removed from the parent either in module land or JS land. This seems to be a workaround to the main problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is a fix for a symptom over the root cause. We don't have reproducable test cause but it seems is is crashing when we use Titanium views with complex layout.

@ingo
Copy link
Contributor

ingo commented Feb 27, 2014

Thank you for the submission. Since we don't have a proper test case and this is a workaround for the issue, we will close the request for now, but please reopen if you find a better way for us to reproduce.

@ingo ingo closed this Feb 27, 2014
@leoafarias
Copy link

2013 was a good year. Guys we are having the same issue that is reported here. However we cannot replicate on a sandbox environment since its a mixture of heaving a very complex layout and the type of content that is being returned from the API. Can we have this approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants