[TIMOB-13419][TIMOB-13421] iOS ListView #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w to be visible simultaneously
…s will not show up in search with style plain
…epSectionsInSearch
ghost
assigned 
| -(void)configureFooter | ||
| { | ||
| if (_footerViewProxy == nil) { | ||
| _footerViewProxy = [[TiViewProxy alloc] init]; |
There was a problem hiding this comment.
Surely this and the headerView, searchWrapper, etc, can use a factory method for a lot of this. (view proxy alloc init, set layout properties.)
| @@ -390,6 +551,20 @@ -(void)setPullView_:(id)args | |||
|
|
|||
| } | |||
|
|
|||
| -(void)setKeepSectionsInSearch_:(id)args | |||
| { | |||
| [self.proxy replaceValue:args forKey:@"keepSectionsInSearch" notification:NO]; | |||
There was a problem hiding this comment.
Doesn't the proxy do this automatically, with the last action being to call setKeepSectionsInSearch_? In other words, is this line redundant?
| -(void)setCaseInsensitiveSearch_:(id)args | ||
| { | ||
| caseInsensitiveSearch = [TiUtils boolValue:args def:YES]; | ||
| [self.proxy replaceValue:NUMBOOL(caseInsensitiveSearch) forKey:@"caseInsensitiveSearch" notification:NO]; |
There was a problem hiding this comment.
shouldn't this be removed too ?
|
Looks good to me. Code Reviewed and APPROVED |
|
Functionally Tested and APPROVED |
srahim
added a commit
that referenced
this pull request
Jul 1, 2013
[TIMOB-13419][TIMOB-13421] iOS ListView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
TIMOB-13419
TIMOB-13421
Use KS PR 106 to test