TIMOB-14505 set activity for avoid null exception #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -252,6 +252,12 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
| public void show(KrollDict options) | |||
| { | |||
| AlertDialog dialog = dialogWrapper.getDialog(); | |||
| if (dialogWrapper.getActivity() == null) { | |||
There was a problem hiding this comment.
you can move this check into the if since activity is only null if dialog is null
|
Code reviewed. Please address comments ASAP. Customer needs this by tomorrow EOD. |
|
modified changes |
| @@ -103,9 +103,17 @@ public DialogWrapper(AlertDialog d, boolean persistent, WeakReference<TiBaseActi | |||
|
|
|||
| public TiBaseActivity getActivity() | |||
| { | |||
| return dialogActivity.get(); | |||
| if (dialogActivity == null) | |||
There was a problem hiding this comment.
sorry my mistake .
Updated
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Jul 19, 2013
…nAlertDialogReusing TIMOB-14505 set activity for avoid null exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14505