timob-14215: Android ActionBar - handle errors gracefully #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the real issue in the ticket is when navBarHidden is set to true, the activity.actionBar will return null. If this is a limitation of the action bar, we should document it. |
|
Thats part of the issue. "navBarHidden=true" is requesting no title bar in android. Action bar is part of the title bar, so there won't be an action bar. The other part is if user doesn't specify targetSDK to 11+, we would still be running into NPE. |
| @@ -9,6 +9,9 @@ description: | | |||
| To access the action bar, you must first open a heavyweight window or tab group that | |||
| uses one of the action bar themes (such as the Android Holo theme). You can then | |||
| access the action bar from the window or tab group's [activity](Titanium.Android.Activity). | |||
| In addition, setting [Window.navBarHidden](Titanium.UI.Window.navBarHidden) or | |||
There was a problem hiding this comment.
In addition, setting the ...
|
Reviewed, ran validate and deploy. Left two minor notes. |
|
DR approved. |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Jul 22, 2013
timob-14215: Android ActionBar - handle errors gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in https://jira.appcelerator.org/browse/TIMOB-14215