TIMOB-14566 add null value checking #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -562,6 +562,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
| } else if (key.equals(TiC.PROPERTY_TOUCH_ENABLED)) { | |||
| doSetClickable(TiConvert.toBoolean(newValue)); | |||
| } else if (key.equals(TiC.PROPERTY_VISIBLE)) { | |||
| newValue = (newValue == null) ? false : newValue; | |||
There was a problem hiding this comment.
I think we need to add this check in TiUIView.processProperties() as well b/c user can set "visible: null" during creation.
| @@ -730,7 +731,7 @@ public void processProperties(KrollDict d) | |||
| } | |||
|
|
|||
| if (d.containsKey(TiC.PROPERTY_VISIBLE) && !nativeViewNull) { | |||
| setVisibility(TiConvert.toBoolean(d, TiC.PROPERTY_VISIBLE, true) ? View.VISIBLE : View.INVISIBLE); | |||
| this.setVisibility(TiConvert.toBoolean(d, TiC.PROPERTY_VISIBLE, false) ? View.VISIBLE : View.INVISIBLE); | |||
There was a problem hiding this comment.
You're modifying default value here. This means that if user don't have the visible flag, the view would be invisible. I think it should be something like this:
visible = d.getProperty(TiC.PROPERTY_VISIBLE);
if (visible != null)
setVisibility(TiConvert.toBoolean(visible, true) ? View.VISIBLE : View.INVISIBLE);
else
setVisibility(View.INVISIBLE)
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Jul 26, 2013
…CauseException TIMOB-14566 add null value checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checked null value
https://jira.appcelerator.org/browse/TIMOB-14566