ios7 ui patch2 #4481
Merged
ios7 ui patch2 #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into ios7_ui_patch2
…e into ios7_ui_patch2
ghost
assigned 
| pickerLabel = [[[UILabel alloc] initWithFrame:theFrame] autorelease]; | ||
| [pickerLabel setTextAlignment:UITextAlignmentLeft]; | ||
| [pickerLabel setBackgroundColor:[UIColor clearColor]]; | ||
| float fontSize = [TiUtils floatValue:[self valueForUndefinedKey:@"fontSize"] def:[TiUtils floatValue:[self valueForUndefinedKey:@"fontSize"] def:18.0]]; |
There was a problem hiding this comment.
shouldn't the default value be just 18.0 ?
|
Code Reviewed and APPROVED |
|
Functionally Tested and APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second set of ui patches for IOS7
Fixes picker UI on IOS7
Fixes tableView selector issue
Fixes most of tableView autosizing issue
Popover bug fix
Known issues:
UI does not update correctly on hiding status bar (still investigating)
tableView search is still unresponsive
Test using KS PR 109