TIMOB-14567 changed default color to black and add null value checking in propertyChanged method #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in propertyChanged method
| @@ -69,7 +70,7 @@ protected void onLayout(boolean changed, int left, int top, int right, int botto | |||
| tv.setFocusable(false); | |||
| tv.setSingleLine(false); | |||
| TiUIHelper.styleText(tv, null); | |||
| defaultColor = tv.getCurrentTextColor(); | |||
There was a problem hiding this comment.
defaultColor is dependent on theme, and is not always black. You shouldn't change this.
|
Code reviewed. Please address comments. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Aug 12, 2013
…hangeToTransparent TIMOB-14567 changed default color to black and add null value checking in propertyChanged method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14567