TIMOB-9991-added a new Android property to disable lightTouchEnabled #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,7 +138,6 @@ public TiUIWebView(TiViewProxy proxy) | |||
| settings.setSupportMultipleWindows(true); | |||
| settings.setJavaScriptCanOpenWindowsAutomatically(true); | |||
| settings.setLoadsImagesAutomatically(true); | |||
| settings.setLightTouchEnabled(true); | |||
There was a problem hiding this comment.
You shouldn't remove this since this is default setting. The developers can set it to false if they want.
There was a problem hiding this comment.
The behaviour didn't change, I just moved this from here to set the value in the 'defaultValues' in the constructor above.
There was a problem hiding this comment.
Ah I didn't see that. Apologies.
|
Code reviewed. Please address comments. |
|
Code reviewed and functionally tested. Also modified test case in JIRA. Request accepted |
| @@ -502,6 +502,20 @@ properties: | |||
| platforms: [iphone, ipad] | |||
| since: "1.8.2" | |||
| default: true | |||
|
|
|||
| - name: lightTouchEnabled | |||
There was a problem hiding this comment.
Add two spaces before the dash.
|
Reviewed. Ran validate and deploy. Left a few comments. |
|
Reviewed. Ran validate and docgen. DR approved. |
hieupham007
added a commit
that referenced
this pull request
Aug 13, 2013
TIMOB-9991-added a new Android property to disable lightTouchEnabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Android only property 'lightTouchEnabled' to turn off the value.