Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-6949 add the header only if that contains the filter value #4523

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Aug 1, 2013

if (keep) {
index.add(i);
if (keep) {
displayHeader(items, i - 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code adds additional headers into the tableview, instead of hiding empty headers. Basically every time we call "index.add(i)", we're adding a row into the tableview, whether it is a header or an actually row.
Here we should have checks to see if the header is empty. If it is, don't add it. You can check for empty header by looking at next values: i.e if item(i) is a header and item(i+1) is a footer or header, we know that it's item(i) is an empty header.
Note that this is just one condition for empty headers(the real solution probably would need more checks since there are a few edge cases we have to consider). The goal here is to HIDE all empty headers AND footers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed
New PR :
#4764

@hieupham007
Copy link
Contributor

Code reviewed. Please address comments.

@bijupmb
Copy link
Contributor Author

bijupmb commented Oct 7, 2013

created new PR

@hieupham007
Copy link
Contributor

closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants