TIMOB-14615 add TYPE_TEXT_FLAG_IME_MULTI_LINE #4544
Conversation
| @@ -119,6 +119,8 @@ public TiUIText(TiViewProxy proxy, boolean field) | |||
| if (field) { | |||
| tv.setSingleLine(); | |||
| tv.setMaxLines(1); | |||
| } else { | |||
| tv.setInputType(InputType.TYPE_TEXT_FLAG_IME_MULTI_LINE); | |||
There was a problem hiding this comment.
This needs to be done in processProperties and propertyChanged, otherwise it will be overwritten in many cases. Please look at handleKeyboard()
There was a problem hiding this comment.
It only depends on field variable ( which is used for checking multi line or single line ) and field variable not changed in processProperties and propertyChanged method then why we changed it in processProperties and propertyChanged methods ?
There was a problem hiding this comment.
This is because there are other places where we call setInputType(). If you call it here at the constructor, then later when another setInputType() is called, it will be overwritten. If you look at handleKeyboard() in TiUIText.java, you will see that we append a bunch of options then set them towards the end of that method. For instance, if I create a TextArea with "autocorrect: false", this fix wouldn't work.
There was a problem hiding this comment.
modified the changes
|
Code reviewed. Please address comments. |
|
FR/CR passed. I confirmed Hieu's comment was addressed and that the modification works on a 4.2 and 2.3 device. @hieupham007 In my opinion you can merge this and resolve ticket. |
| @@ -547,6 +550,9 @@ public void handleReturnKeyType(int type) | |||
| tv.setImeOptions(EditorInfo.IME_ACTION_DONE); | |||
| break; | |||
| case RETURNKEY_SEARCH: | |||
| if (!field) { | |||
There was a problem hiding this comment.
I think this needs to be done for all return keys, not just search.
|
Code reviewed. Looks good, just a couple minor comments :) |
|
The last commit broke the new functionality. The search button no longer appears (tested on Jelly Bean and Gingerbread devices.) |
| @@ -530,6 +533,9 @@ public void setSelection(int start, int end) | |||
|
|
|||
| public void handleReturnKeyType(int type) | |||
| { | |||
| if (!field) { | |||
| tv.setInputType(tv.getInputType() | InputType.TYPE_TEXT_FLAG_IME_MULTI_LINE); | |||
There was a problem hiding this comment.
apologies. tv.getInputType() is returning a different inputType... I think the right approach is to delete this if statement entirely then in handleKeyboard() if clause of processProperties(), add an else if clause to set the inputType. I.e:
public void processProperties(KrollDict d) {
...
if (...) {
handleKeyboard(d);
} else if (!field) {
tv.setInputType(InputType.TYPE_TEXT_FLAG_IME_MULTI_LINE);
}
| @@ -192,6 +192,8 @@ public void processProperties(KrollDict d) | |||
|
|
|||
| if (d.containsKey(TiC.PROPERTY_KEYBOARD_TYPE) || d.containsKey(TiC.PROPERTY_AUTOCORRECT) || d.containsKey(TiC.PROPERTY_PASSWORD_MASK) || d.containsKey(TiC.PROPERTY_AUTOCAPITALIZATION) || d.containsKey(TiC.PROPERTY_EDITABLE)) { | |||
| handleKeyboard(d); | |||
| }else if (!field) { | |||
There was a problem hiding this comment.
need a space between } and else
|
Code reviewed and functionally tested. Looks good. Just a couple minor comments |
|
Code reviewed and functionally tested. Request accepted |
|
@billdawson are you ok with this? :) |
|
@hieupham007 Looks good to me. :-) |
…TextArea TIMOB-14615 add TYPE_TEXT_FLAG_IME_MULTI_LINE
https://jira.appcelerator.org/browse/TIMOB-14615